Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] 이상한 질문 저장 하지 않는 로직 추가 #67

Merged
merged 9 commits into from
Aug 17, 2024
Merged

[refactor] 이상한 질문 저장 하지 않는 로직 추가 #67

merged 9 commits into from
Aug 17, 2024

Conversation

Hoya324
Copy link
Member

@Hoya324 Hoya324 commented Aug 14, 2024

✅ 작업 내용

  • 이상한 질문 저장 하지 않는 로직 추가
  • 도메인과 관련 없는 질문(예: 수시에서 내 점수면 합격할 수 있어?)이 오는 경우 저장하지 않도록 함

추가 작업

  • 해당 로직에 대한 테스트

@Hoya324 Hoya324 self-assigned this Aug 14, 2024
@Hoya324 Hoya324 added the 🎯리팩토링 기존의 기능을 디벨롭한 pr입니다. label Aug 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

Unit Test Results

94 tests   94 ✔️  13s ⏱️
16 suites    0 💤
16 files      0 ❌

Results for commit 91d841a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Code Coverage

File Coverage [100%] 🍏
AdminQuestionController.java 100% 🍏
AdminAnswerController.java 100% 🍏
Total Project Coverage 74.52% 🍏

@Hoya324 Hoya324 merged commit f957e8c into develop Aug 17, 2024
2 checks passed
@Hoya324 Hoya324 deleted the refactor/이상한-질문-저장-하지-않음 branch August 17, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Hoya324 Hoya324

Labels
🎯리팩토링 기존의 기능을 디벨롭한 pr입니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hoya324